Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 105 incomplete scripts #107

Merged
merged 15 commits into from
Sep 26, 2024
Merged

Issue 105 incomplete scripts #107

merged 15 commits into from
Sep 26, 2024

Conversation

jayware9
Copy link
Member

@jayware9 jayware9 commented Sep 6, 2024

Added scripts for session 1 and 2:

  • working_script.R: incomplete code examples, exercise questions and hints
  • solutions.R: complete code examples, and exercise solutions

Updated read-me to refer to these scripts

#105

@jayware9
Copy link
Member Author

Feedback from Lorna:

Session 1

Rmarkdown

Line 723: In the above code, R is taking the 'iris' dataset, grouping it by Species and then (note that the data is "piped" like water…

Line 991: The url: Data transformation with dplyr :: Cheatsheet (rstudio.github.io) is redirected to this page: Posit | The Open-Source Data Science Company. I didn’t know if we should use this page as the link: Data transformation with dplyr :: Cheatsheet (rstudio.github.io) so it’s easier for students for find the cheat sheet on joins.

Line 1042: The current link for the R data science pdf is blocked but I think this one works fine: R for Data Science (2e) (hadley.nz)

Line 1044: same as line 991, I think this could be replaced with: Cheatsheets - Posit

Line 1048: We could put a link to the sharepoint site: R Resources (sharepoint.com)

Working script

Line 290: #4.2.1
write_csv(iris_petals, path file= "iris_petals.csv")

Session 2

Working script

Section 4.1: The code in section 4.1 look to be the full answers but I didn’t know if that was intended to make it easier for the students to follow this section.

R markdown

Line 265: ###4.2 Exercise ### 4.2 Exercise
(HTML is not picking up sub title formatting)

General

Do we need to keep the incomplete RMD files in the folders, if we have the HTML output and the working scripts?

@jayware9
Copy link
Member Author

Thanks @lorna29 I've made the changes you suggested. Did you want to take another look over it, or do you think it's ready to merge into main?

@lorna29 lorna29 merged commit f5d931d into main Sep 26, 2024
@lorna29 lorna29 deleted the issue-105-incomplete-scripts branch September 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants